Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Change Holo dialogs to Material #270
Open
Conversation
|
I've tried this changes in API 19 and dialogs are not rendered properly. Need to check with API >= 21 yet. |
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) | ||
| return new LightAlertDialog(context, Theme_Material_Light_Dialog_Alert); | ||
| else | ||
| return new LightAlertDialog(context, Theme_Holo_Light_Dialog); |
jonan
Mar 29, 2017
Owner
This two calls should be new LightAlertDialog.Builder(...)
This two calls should be new LightAlertDialog.Builder(...)
| @@ -17,9 +17,14 @@ | |||
|
|
|||
| import android.app.AlertDialog; | |||
| import android.content.Context; | |||
| import android.os.Build; | |||
|
|
|||
| import static android.R.style.Theme; | |||
jonan
Mar 29, 2017
Owner
This import is not needed
This import is not needed
|
@jonan Are you working on this? if not I can make the necessary changes suggested by you and raise a PR. |
|
Sorry it's been a while, I just added the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This change allows Material dialogs to be used if available (running Lollipop or above), while maintaining support for API < 21.
THEME_HOLO_LIGHTis also apparently deprecated, so it has been replaced.