The Wayback Machine - https://web.archive.org/web/20201105103054/https://github.com/camunda/camunda-modeler/issues/1538
Skip to content

/ camunda-modeler

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep original viewport when switching back from table to DRD view #1538

Open
mschoe opened this issue Oct 17, 2019 · 6 comments
Open

Keep original viewport when switching back from table to DRD view #1538

mschoe opened this issue Oct 17, 2019 · 6 comments
Labels
backlog easy enhancement good first issue hacktoberfest

Comments

@mschoe
Copy link
Member

@mschoe mschoe commented Oct 17, 2019 •
edited by pinussilvestrus

Describe the Bug

When switching between the DRD and a sub view (decision table, literal expression) the DRD viewbox is reset to (0,0) on any sub view change. I'd expect the viewbox to stay where it originally was so that users have a better switching behavior.

Steps to Reproduce

PlacementIssureDRD

  • I'm in the DMN table view and save my latest changes
  • I switch from the DMN table view to the DRD view
  • The decision element is focused in the upper left corner of the view and is partially hidden by the element palette

Describe the Solution

  • I would expect that the modeler keeps the original viewport when I switch back to the DRD view.

Additional Context

This has to be fixed in dmn-js

Environment
affects all OS
modeler v. 3.4.0
@nikku
Copy link
Member

@nikku nikku commented Oct 18, 2019

From what I understand you're asking for the following:

Keep the current DRD viewport when switching to other editors and back to the DRD.
Or in other words, if I centered the diagram, switch to a table, switch back, the diagram should still be centered at the previous position.

Does that summarize your feature request?
@nikku nikku added the help wanted label Oct 18, 2019
@philippfromme philippfromme changed the title Missing offset when swithching from table to DRD view Missing offset when switching from table to DRD view Oct 22, 2019
@mschoe
Copy link
Member Author

@mschoe mschoe commented Nov 5, 2019

I think the following screencast demonstrates it much better. I would expect that the modeler keeps the the viewport when I switch to the dmn view.

drd_dmn_switch
@nikku nikku added enhancement backlog and removed help wanted labels Nov 5, 2019
@nikku
Copy link
Member

@nikku nikku commented Nov 5, 2019

Thanks for clarifying. A legit feature request. 👍
@mschoe
Copy link
Member Author

@mschoe mschoe commented Nov 5, 2019

❤️
@nikku nikku changed the title Missing offset when switching from table to DRD view Keep original viewport when switching back from table to DRD view Nov 5, 2019
@iamparthshukla
Copy link

@iamparthshukla iamparthshukla commented Oct 1, 2020

Is this issue up for someone to work on? I would love to give this a try!
@techytushar
Copy link

@techytushar techytushar commented Oct 8, 2020

Hey @nikku @pinussilvestrus I would like to work on this, please can you tell in which files I should look into in dmn-js. I tried to figure it out but I am not able to since there are a lot of files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog easy enhancement good first issue hacktoberfest
5 participants
@nikku @mschoe @pinussilvestrus @techytushar @iamparthshukla
You can’t perform that action at this time.