The Wayback Machine - https://web.archive.org/web/20200629190731/https://github.com/maxbbraun/trump2cash/issues/24
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which direction you are trading in based on sentiment #24

Open
markstos opened this issue Feb 10, 2017 · 7 comments
Open

Document which direction you are trading in based on sentiment #24

markstos opened this issue Feb 10, 2017 · 7 comments

Comments

@markstos
Copy link

@markstos markstos commented Feb 10, 2017

It's not clear from the current docs whether you buy or sell stock for a company that Trump complains about.

You should state your bias about your expectation about Trump's tweets effect on stock prices. (Note that Nordstorm stock went up after Trump complained about them).

@Se1ecto
Copy link

@Se1ecto Se1ecto commented Feb 11, 2017

Perhaps it depends on whether or not he actually has the political power to follow his tweets?

@BernsteinA
Copy link

@BernsteinA BernsteinA commented Feb 11, 2017

It may not be in the docs but it's right there in trading.py

@markstos
Copy link
Author

@markstos markstos commented Feb 12, 2017

It should be in the README. If you are going to bet money on someone's advice, it's important to know upfront whether you are betting for or against the advice!

@domingohui
Copy link

@domingohui domingohui commented Feb 13, 2017

@markstos You meant we should document what the bot should do following a Trump's tweet?
e.g. (in README would be) if Trump says good things about a company, then the bot will go long on the company, and vice versa.

from README

automatically executes trades on the relevant stocks according to the expected market reaction

I agree this is a bit ambiguous, but not quite when it comes to Trump the President :D

@markstos
Copy link
Author

@markstos markstos commented Feb 13, 2017

@BernsteinA
Copy link

@BernsteinA BernsteinA commented Feb 13, 2017

@markstos if you are going to run an open source bot that spends your own money, you should check out the code and not just trust the readme anyway :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.