The Wayback Machine - https://web.archive.org/web/20200515040529/https://github.com/webpack/webpack.js.org/issues/3538
Skip to content

/ webpack.js.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Add keyboard shortcut to documentation to toggle sidebar navigation #3538

Open
plug-n-play opened this issue Feb 14, 2020 · 6 comments
Open

Documentation: Add keyboard shortcut to documentation to toggle sidebar navigation #3538

plug-n-play opened this issue Feb 14, 2020 · 6 comments

Comments

@plug-n-play
Copy link
Contributor

@plug-n-play plug-n-play commented Feb 14, 2020

Feature request

In the official documentation, it would be great to add keyboard shortcut which toggles sidebar navigation and helps people like me who get distracted easily from following existing view:
image

to this:

image

using:
document.querySelector('.sponsors').style.display = 'none'
and
document.querySelector('.sidebar.site__sidebar').style.display = 'none'

What is the expected behavior?
Suggested screen-shot added above

What is motivation or use case for adding/changing the behavior?
To help people which get distracted easily

How should this be implemented in your opinion?
Add a keyboard shortcut in docs to listen to say Alt+Z to toggle left navigation

Are you willing to work on this yourself?
yes, given some helping hand on my first PR for Webpack
@sokra sokra transferred this issue from webpack/webpack Feb 14, 2020
@anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Feb 14, 2020

did you zoom-out or its the default behavior of showing that sponsor banner.?
@plug-n-play
Copy link
Contributor Author

@plug-n-play plug-n-play commented Feb 15, 2020

I did not zoom out, but used only a portion of the screen as screen capture. Here is another full screen capture for comparison:

image
@anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Feb 15, 2020

I did not zoom out, but used only a portion of the screen as screen capture. Here is another full screen capture for comparison:

image

I think the sponsor thing should not be there. !!!!!

even toggling sidebar seems fine enhancement !!

cc @montogeek
@anshumanv
Copy link
Contributor

@anshumanv anshumanv commented Feb 15, 2020

I think the sponsor thing should not be there. !!!!!

I don't think removing the sponsors is a good idea. Unsure about removing sidebar too.
@anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Feb 15, 2020

I think the sponsor thing should not be there. !!!!!

I don't think removing the sponsors is a good idea. Unsure about removing sidebar too.

yeah...even I thought about the sponsor and it seems it should be there
and about the toggling, I guess the default will be it will be visible but we can add a toggle.
maybe...even the current is good....
@plug-n-play
Copy link
Contributor Author

@plug-n-play plug-n-play commented Feb 18, 2020 •
edited

No comments on the Sponsors logo being there. The default behaviour can stay as it is. Just a feature enhancement to make the docs more accessible to read. A keyboard shortcut which toggles between existing view and the Medium like, distraction free view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@plug-n-play @anshumanv @anikethsaha
You can’t perform that action at this time.