The Wayback Machine - https://web.archive.org/web/20201206150547/https://github.com/docker/app/issues/424
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute validate command before pushing or deploying #424

Open
jonathansantilli opened this issue Dec 3, 2018 · 2 comments
Open

Execute validate command before pushing or deploying #424

jonathansantilli opened this issue Dec 3, 2018 · 2 comments

Comments

@jonathansantilli
Copy link

@jonathansantilli jonathansantilli commented Dec 3, 2018

At the Dockercon18, Workshop: Docker Application Package, I have asked if the command validate is executed before sharing or deploying the app.
Since there was not a clear answer about it, they encouraged me to open this issue/question.
I have checked the code and seems that is not called, maybe is called, but I could not find it.
In my opinion would be great to ensure the app is valid before pushing or deploying.

@silvin-lubecki
Copy link
Collaborator

@silvin-lubecki silvin-lubecki commented Dec 3, 2018

Thank you @jonathansantilli for filling his issue! You are right about that, we should validate everytime before bundling, deploying or pushing.

@simonferquel
Copy link
Contributor

@simonferquel simonferquel commented Jan 14, 2019

The move to CNAB runtime will build a CNAB each time you try to deploy or push from source, thus validating the package as a nice side effect. We should not spend too much effort on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.