Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Remove the revokable proxy behavior inherited from Bot Framework #1841
Comments
|
Can you please see my comment on #1856 , I met some issues on that :( |
|
I think you misunderstand what this ticket is about. This would be a change to the code inside the Botkit adapters to use a different base class - not a change to your bot code. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not stale. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
still not stale! changes underway in bot framework SDK to allow this. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Is your feature request related to a problem? Please describe.
The current behavior of turning the "turn context" into a revokable proxy that stops working is hard to deal with and difficult to explain. We should (optionally) remove it from the Botkit adapters.
Describe the solution you'd like
By deriving a new class from BotAdapter, then changing all Botkit adapters to derive from that.
When used with Botkit the proxy behavior should be disabled by default.
Otherwise it should be on by default (this is the expected behavior when used with Bot Framework)