The Wayback Machine - https://web.archive.org/web/20201213130229/https://github.com/howdyai/botkit/issues/1841
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the revokable proxy behavior inherited from Bot Framework #1841

Closed
benbrown opened this issue Oct 28, 2019 · 10 comments
Closed

Remove the revokable proxy behavior inherited from Bot Framework #1841

benbrown opened this issue Oct 28, 2019 · 10 comments
Assignees
Labels

Comments

@benbrown
Copy link
Contributor

@benbrown benbrown commented Oct 28, 2019

Is your feature request related to a problem? Please describe.
The current behavior of turning the "turn context" into a revokable proxy that stops working is hard to deal with and difficult to explain. We should (optionally) remove it from the Botkit adapters.

Describe the solution you'd like
By deriving a new class from BotAdapter, then changing all Botkit adapters to derive from that.

When used with Botkit the proxy behavior should be disabled by default.
Otherwise it should be on by default (this is the expected behavior when used with Bot Framework)

@movi1224
Copy link

@movi1224 movi1224 commented Nov 13, 2019

Can you please see my comment on #1856 , I met some issues on that :(

@benbrown
Copy link
Contributor Author

@benbrown benbrown commented Nov 13, 2019

I think you misunderstand what this ticket is about.

This would be a change to the code inside the Botkit adapters to use a different base class - not a change to your bot code.

@stale
Copy link

@stale stale bot commented Jan 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 12, 2020
@benbrown benbrown removed the stale label Jan 13, 2020
@stale
Copy link

@stale stale bot commented Mar 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 13, 2020
@benbrown
Copy link
Contributor Author

@benbrown benbrown commented Mar 13, 2020

Not stale.

@stale stale bot removed the stale label Mar 13, 2020
@stale
Copy link

@stale stale bot commented May 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 13, 2020
@benbrown
Copy link
Contributor Author

@benbrown benbrown commented May 13, 2020

not stale

@stale stale bot removed the stale label May 13, 2020
@stale
Copy link

@stale stale bot commented Jul 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 12, 2020
@stale stale bot closed this Jul 19, 2020
@benbrown
Copy link
Contributor Author

@benbrown benbrown commented Jul 20, 2020

still not stale! changes underway in bot framework SDK to allow this.

@benbrown benbrown reopened this Jul 20, 2020
@stale stale bot removed the stale label Jul 20, 2020
@stale
Copy link

@stale stale bot commented Sep 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 20, 2020
@stale stale bot closed this Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.