The Wayback Machine - https://web.archive.org/web/20200914232729/https://github.com/Breakthrough/PySceneDetect/issues/116
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete documentation for Video Splitter API #116

Closed
dynamite-ready opened this issue Sep 11, 2019 · 5 comments
Closed

Complete documentation for Video Splitter API #116

dynamite-ready opened this issue Sep 11, 2019 · 5 comments
Assignees
Milestone

Comments

@dynamite-ready
Copy link

@dynamite-ready dynamite-ready commented Sep 11, 2019

Bug/Issue Description:
Calls to scenedetect.video_splitter.split_video_mkvmerge end with a ERROR:root:Error splitting video (mkvmerge returned 2).

Required Information:
Provide the following information to assist with reporting the bug:

  1. Provide a full copy of the command line options you are using, for example:

Example Python API call:
scenedetect.video_splitter.split_video_mkvmerge(str(video_path), scene_list, "test", "tests", suppress_output=False)

  1. Add -v debug -l BUG_REPORT.txt to the beginning of the command, then re-run PySceneDetect and attach the generated BUG_REPORT.txt file.

Expected Behavior:
mkvmerge v37.0.0 ('Leave It') 64-bit 'spring.mp4': Using the demultiplexer for the format 'QuickTime/MP4'. 'spring.mp4' track 0: Using the output module for the format 'AVC/H.264'. 'spring.mp4' track 1: Using the output module for the format 'AAC' # etc...

Computing Environment:

  • OS: Windows 10
  • Python Version: 3.7
  • OpenCV Version: Unknown

Additional Information:
Fixed by a small change to the method in question.
A commit on my fork with a candidate fix can be found here - dynamite-ready@3006d87

@Breakthrough
Copy link
Owner

@Breakthrough Breakthrough commented Sep 12, 2019

Hello @dynamite-ready;

The input_video_paths argument should be a list of strings, not a string itself. If you refactor the call you have above to the following:

scenedetect.video_splitter.split_video_mkvmerge([str(video_path)], scene_list, "test", "tests", suppress_output=False)

That should resolve the error that you're seeing. The intention of the split_video_ functions is to allow multiple videos as input files, which will be concatenated together in the output.

Please let me know if passing a list of file paths (instead of a single path) works as intended so that I can resolve the issue.

@dynamite-ready
Copy link
Author

@dynamite-ready dynamite-ready commented Sep 12, 2019

Lol! Yes. That worked fine.

I'd perhaps argue that it could be made a little clearer in the docs - https://pyscenedetect-manual.readthedocs.io/en/latest/api/video_splitter.html - but your explanation helped.

Thank you.

@Breakthrough Breakthrough added this to the v0.5.2 milestone Sep 13, 2019
@Breakthrough Breakthrough changed the title Calls to `scenedetect.video_splitter.split_video_mkvmerge` end with mkvmerge error Complete documentation for Video Splitter API Sep 13, 2019
@Breakthrough Breakthrough reopened this Sep 13, 2019
@Breakthrough
Copy link
Owner

@Breakthrough Breakthrough commented Sep 13, 2019

@dynamite-ready very good point! I've modified the title to better reflect that and reopened the issue to take care of that. I'll try to include the proper documentation for those arguments in the next release, thanks for pointing that out.

@Breakthrough
Copy link
Owner

@Breakthrough Breakthrough commented Jun 27, 2020

Ping: Revisit this next week for v0.6. Top priorities right now are resolving ffmpeg split issues and camera flash issue resolution, but I don't want to lose track of quality-of-life items like this one.

@Breakthrough
Copy link
Owner

@Breakthrough Breakthrough commented Jun 29, 2020

For some reason, the documentation that now gets generated is completely blank for the video splitter. I've submitted a support request for ReadTheDocs (readthedocs/readthedocs.org#7245), but in the meantime I'll try to come up with a workaround.

Either way, I'll get this closed out this week as well, but just wanted to keep you posted.

Breakthrough added a commit that referenced this issue Jun 29, 2020
@Breakthrough Breakthrough added this to Done in v0.6 Release Jul 4, 2020
@Breakthrough Breakthrough unpinned this issue Jul 12, 2020
@Breakthrough Breakthrough moved this from Done2 to Done in v0.6 Release Jul 19, 2020
@Breakthrough Breakthrough modified the milestones: v0.6, v0.5.4 Sep 12, 2020
@Breakthrough Breakthrough removed this from Done in v0.6 Release Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.