The Wayback Machine - https://web.archive.org/web/20210131075423/https://github.com/DarkstarProject/darkstar/issues/5729
Skip to content
This repository has been archived by the owner. It is now read-only.

calling `UpdateNMSpawnPoint()` on NMs with no alternate spawn points #5729

Open
TeoTwawki opened this issue Feb 11, 2019 · 2 comments
Open

calling `UpdateNMSpawnPoint()` on NMs with no alternate spawn points #5729

TeoTwawki opened this issue Feb 11, 2019 · 2 comments
Labels

Comments

@TeoTwawki
Copy link
Member

@TeoTwawki TeoTwawki commented Feb 11, 2019

I have:

  • searched existing issues (http://github.com/darkstarproject/darkstar/issues/) to see if the issue I am posting has already been addressed or opened by another contributor
  • checked the commit log to see if my issue has been resolved since my server was last updated

Client Version (type /ver in game) :
n/a

Source Branch (master/stable) :
I AM THE MASTER /kungfumusic

Additional Information (Steps to reproduce/Expected behavior) :

"UpdateNMSpawnPoint: SQL error: No entries for mobid <number here> found."

17219886, Rampaging Ram
17211702, Maighdean Uaine
17220001, Bendigeit Vran
17309954, Despot
thanks Wren.

All trigger that log error. I'm sure there are more as well. These actually should have multiple spawn pos, but I also feel we could be handling this better than just assuming every NM has multiple pos entries in that sql table / auto calling this function in the global on every NM. These log messages aren't making anyone go capture retail pos and we can see which NM need pos data using a very simple SQL query.

@TeoTwawki TeoTwawki added the Easy Fix label Feb 11, 2019
@KnowOne134
Copy link
Contributor

@KnowOne134 KnowOne134 commented Feb 11, 2019

There are alot that are coded with the original spawnpoint and have 1 nm spawn point. Both being the same pos

@wrenffxi
Copy link
Contributor

@wrenffxi wrenffxi commented Feb 12, 2019

those are in there pretty much to avoid this exact message.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants