Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprovement docs about filters #573
Open
Labels
Comments
|
agree on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


I find better code about filters than in docs which allow write less code when we declare fields.
Instead of (see http://django-shop.readthedocs.io/en/latest/reference/filters.html#id3):
I suggest:
Other words I changed
FilterFormand removewidget=Select(attrs={'ng-change': 'filterChanged()'}),to we don't need write it every time.I suggest to fix django shop documentation about filters, adding more information about how django-shop auto adds attributes
ng-modelandng-changeto html inputs. Also I suggest to add this information to http://django-angular.readthedocs.io/en/latest/angular-model-form.html (Excuse me if I miss information about it).P. S. If you agree with me I can add pull request.