The Wayback Machine - https://web.archive.org/web/20200916021422/https://github.com/hyperium/hyper/issues/1848
Skip to content

/ hyper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests for 0.13 #1848

Closed
seanmonstar opened this issue Jul 9, 2019 · 5 comments
Closed

Re-enable tests for 0.13 #1848

seanmonstar opened this issue Jul 9, 2019 · 5 comments
Labels
A-tests E-easy
Milestone
0.13

Comments

@seanmonstar
Copy link
Member

@seanmonstar seanmonstar commented Jul 9, 2019 •
edited

As part of merging #1836 (related to #1805), running the tests in CI was disabled. They should be re-enabled as we go along.

  • The --lib tests
  • benches directory
  • tests/client
  • tests/server
  • tests/integration
@seanmonstar seanmonstar added this to the 0.13 milestone Jul 9, 2019
@rye rye mentioned this issue Jul 11, 2019
Closed
@weihanglo weihanglo mentioned this issue Jul 17, 2019
Merged
0 of 2 tasks complete
@seanmonstar seanmonstar mentioned this issue Jul 19, 2019
Closed
4 of 5 tasks complete
@weihanglo weihanglo mentioned this issue Jul 21, 2019
Merged
0 of 1 task complete
@jakubadamw
Copy link
Contributor

@jakubadamw jakubadamw commented Jul 23, 2019

The tests/client bit is done in #1881.
@apiraino
Copy link

@apiraino apiraino commented Aug 27, 2019 •
edited

@seanmonstar or anyone else, could you pls also add an example on how to use the Service and MakeService trait?

(I'm on Hyper 0.12 and having a hard time to figure that out. I'd be happy if for 0.13 that to be more discoverable).

thanks 👍

By the way: examples are of the essence for a library and I thank you so much for having written them! More of them, pls :-)

EDIT: https://stackoverflow.com/questions/57371130/hyper-0-12-x-implementing-service-for-a-struct
@Mathspy
Copy link

@Mathspy Mathspy commented Sep 7, 2019

I think this is finally closed by #1882
@weihanglo
Copy link
Contributor

@weihanglo weihanglo commented Sep 9, 2019

@Mathspy
Not really. Some tests under src/client are still disabled. Most related to a new mock service implementations.
@seanmonstar
Copy link
Member Author

@seanmonstar seanmonstar commented Sep 11, 2019

I'm going to close this, as almost all tests have been re-enabled. I've removed the warning about the missing tests in client/tests.rs, as re-writing them is rather tricky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests E-easy
5 participants
@seanmonstar @Mathspy @apiraino @jakubadamw @weihanglo
You can’t perform that action at this time.