Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upisIBAN & isBIC #951
isIBAN & isBIC #951
Comments
|
I'm working right now on isIBAN |
|
I will check on @NizarGhazouani PR. Though, it seems, it needs some updates. But, if someone wants to check on it, here are some notes/guidelines. SWIFT / BIC codes should contain the following:
cc. @profnandaa |
|
I will also see that, I can work on validating the |
- validate valid BIC - refers part of validatorjs#951
- validate valid BIC - refers part of validatorjs#951
- fix linter issues - fix tests - seperate unnecessary files changes - closes validatorjs#1034 validatorjs#951 - Other references validatorjs#1071
- fix linter issues - fix tests - seperate unnecessary files changes - closes validatorjs#1034 validatorjs#951 - Other references validatorjs#1071
- fix linter issues - fix tests - seperate unnecessary files changes - closes validatorjs#1034 validatorjs#951 - Other references validatorjs#1071
- fix linter issues - fix tests - seperate unnecessary files changes - closes validatorjs#1034 validatorjs#951 - Other references validatorjs#1071
- validate valid BIC - refers part of validatorjs#951
|
@profnandaa @ezkemboi PR #1243 introduces an implementation to the |
|
It's seems to be possible to add emojis or any special character (!@#...) to the IBAN, and it will still pass the validation, could you fix this ? The following function in isIBAN.js seems buggy:
Why testing the stripped string ? |
|
@GoMino, I will try to reproduce that bug, but don't hesitate to raise a PR or solution in case you come across the best possible way to resolve the issue. cc. @profnandaa |
|
@ezkemboi pull request created! thanks |


Could you implement those function inside the validator ?
Those would be very usefull .
Thank you .