The Wayback Machine - https://web.archive.org/web/20201020214852/https://github.com/awslabs/aws-shell/issues/171
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "exit" or "quit" get you out of the shell #171

Open
kennyk65 opened this issue Mar 1, 2017 · 15 comments
Open

Make "exit" or "quit" get you out of the shell #171

kennyk65 opened this issue Mar 1, 2017 · 15 comments

Comments

@kennyk65
Copy link

@kennyk65 kennyk65 commented Mar 1, 2017

ctrl-D? Who would guess that. Make it easier by supporting common sense notions for leaving the shell.

@donnemartin
Copy link
Collaborator

@donnemartin donnemartin commented Mar 2, 2017

Hi @kennyk65, aws-shell has dot commands so running either of the following commands will terminate the shell:

aws> .quit
aws> .exit

In the README we make note of .cd and .profile but not .quit/.exit.

I think we could probably make these commands more discoverable.

@kennyk65
Copy link
Author

@kennyk65 kennyk65 commented Mar 6, 2017

I would never guess to try ".exit" or ".quit". Why force customers to look in the documentation when they only wish to leave the tool?

@softmonkeyjapan
Copy link

@softmonkeyjapan softmonkeyjapan commented Jun 27, 2017

@donnemartin or maybe just do like EVERYONE is doing, provide a quit and/or exit methods. Seriously!!

@joguSD
Copy link
Contributor

@joguSD joguSD commented Jul 31, 2017

I can definitely understand the frustration behind not being able to exit the shell. The problem with allowing arbitrary commands is the potential for naming collisions with services under the aws command. The idea is that the commands you type are under the prefix aws and thus just exit would equate to aws exit. If we make a special exception for some commands and not others may only further confusion. That being said, such a fundamental command may be worthy of the exception. @jamesls Any thoughts on this?

@jamesls
Copy link
Member

@jamesls jamesls commented Aug 7, 2017

Yeah, I'm interested in a better solution here, but I think we should at least start with documenting .quit and .exit. While it seems highly unlikely there will ever be an exit or quit command in the AWS CLI (i.e aws exit), it does make things inconsistent with the way that namespace is used for other services (e.g aws ec2 ...).

Checking out a few existing REPLs: python, node don't have quit/exit commands, but irb and ipython do. It seems like it's not entirely consistent to always add quit/exit commands.

I'd say, let's leave this issue open. If people feel strongly about this, please +1 this issue. That will help give us feedback if people want this or are fine with the .quit/.exit commands. I think that's probably the best way to decide.

@jpz
Copy link

@jpz jpz commented Nov 4, 2017

Alternatively, some guidance on how to discover the dot commands when first starting up would be good - ipython for instance tells you "press ?" to know more. The design of the .exit / .quit makes sense, but are not easily discoverable.

On the other hand, it didn't me long to discover ^D, after quit and exit didn't work, it was the next obvious go-to, though this might be less obvious to Windows users (and in which case it would likely be ^Z)

It does seem annoying that "exit" doesn't work however, personally I'd prefer to see that additionally supported, alternatively - describing the presence of the .dot commands and how to bring up a quickref for them (e.g. "?") would be a workable alternative.

@jleaders
Copy link

@jleaders jleaders commented Mar 23, 2018

I've been using AWS Shell for several weeks now, mostly because I can't figure out how to exit it.

@ladydata
Copy link

@ladydata ladydata commented May 4, 2018

Ironically, the only place I could find info about how to quit the terminal is... this Github issue!

@sahas-
Copy link

@sahas- sahas- commented Oct 1, 2018

+1

@tdmalone
Copy link

@tdmalone tdmalone commented Mar 18, 2019

What about support for Ctrl+C? That's the first thing I tried...

@JeffMangan
Copy link

@JeffMangan JeffMangan commented Oct 1, 2019

I would never guess to try ".exit" or ".quit". Why force customers to look in the documentation when they only wish to leave the tool?

Because I have to install "Cheese" in order to use my webcam with Ubuntu. Sounds pretty obvious to me eh !

@leandropadua
Copy link

@leandropadua leandropadua commented Nov 15, 2019

I've just installed it on mac and I've noticed when I started, it creates a bar on the bottom:

[F2] Fuzzy: ON  [F3] Keys: Emacs  ...  [F10] Exit 

hence, pressing F10 (or fn + F10 on new macs) also exit the shell.

@progzilla
Copy link

@progzilla progzilla commented Jan 5, 2020

I've just installed it on mac and I've noticed when I started, it creates a bar on the bottom:

[F2] Fuzzy: ON  [F3] Keys: Emacs  ...  [F10] Exit 

hence, pressing F10 (or fn + F10 on new macs) also exit the shell.

Interestingly this doesn't work for Linux but i found .q helped out.

@hholst80
Copy link

@hholst80 hholst80 commented Jan 27, 2020

Why did the F10 not work on "Linux"? Is it captured by the terminal emulator? Try Esc 0 or try running aws-shell from the TTY?

@elshaddae
Copy link

@elshaddae elshaddae commented Feb 3, 2020

F10 on ubuntu opens the top menu bar of the terminal. I just installed the package and the interesting thing is that this issue is still opened for almost 3 years now and l landed here just to help myself exit. How hard is it to make Ctrl+C for exit and make Ctrl+D for keyboard interrupt? It should be 2 line edit on code and docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.