Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Refactor interactive tests #6432
Comments
|
It might even make sense to combine this with allowing multiple expectation blocks per test already - then a common class would split the input into source and multiple expectation blocks, determine which kind of test each expectation block is (and parse common settings) and then let the specific test case handle the rest. |
|
@ekpyron I think we should first clean up the mess and then make it more complicated again :) |
|
I think really cleaning it up would basically mean rewriting quite some parts of it and then one might as well split into multiple expectation blocks right away, since otherwise we'll probably rewrite things once more later on anyways :-). But yeah - both would be fine and I would say whoever actually does this can decide which seems better and easier. |
|
I would like to work on it. I have some experience in C++. This seems to look like something interesting to work on. |
|
@maharsh312 That sounds great! Do you need some guidance on where to start or a more detailed explanation of what has been discussed in this issue? Just let us know what's needed to get you started on this. We're more than happy to help! |
|
One piece of code you could look out for is
This is shared in quite some files. Especially if |
|
I think I don't need help as of now. Do you guys have an IRC? |
Never Mind. Found It! |
|
Is this issue still open? I'm trying to find good first issues to start contributing to open source. |
|
@kennycastro007 We thought this one might be a good issue for you to start on, if you like. If you need help you can talk to us in our gitter channel https://gitter.im/ethereum/solidity-dev. When you start working on this, please assign the issue to you. |
|
I believe ppl not part of the team can't assign issues. Just let us now if that is the case and we'll assign it for you. |
|
I think after #9059 this looks good now! |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Many interactive tests share common functionality and functionslike
printIndented. They should be pulled into a common base class.Also, a "simple" interactive test that just has an input and an output (and comparison is string comparison) could profit from a simple combined base class.