Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTest Additions for JS Array Functions #31
Closed
Conversation
…type.keys() functions.
|
Adding tests is always helpful, thanks! We already have some array iteration tests in |
|
Thanks @avp! I have added tests to the |
|
@avp is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
added a commit
that referenced
this pull request
Jan 14, 2020
Summary: ## Motivation Why are you making this change? What did you change? How does the code work? Why did you choose this approach? Pull Request resolved: facebookincubator/fbjni#31 Test Plan: How did you test this change? Any change that adds functionality should add a unit test as well. Reviewed By: BurntBrunch Differential Revision: D19348810 Pulled By: passy fbshipit-source-id: 7a144c80cc1078d968a562a17fa8d5f84047eeb2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The Hermes VM currently has support for Javascript's
Array.prototype.values()andArray.prototype.keys()functions but tests for them were yet to be included.I worked on tests for both functions in this pull request.