The Wayback Machine - https://web.archive.org/web/20220508010919/https://github.com/graphile/postgraphile/pull/1077
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf): performance enhancements #1077

Merged
merged 43 commits into from May 17, 2019
Merged

feat(perf): performance enhancements #1077

merged 43 commits into from May 17, 2019

Conversation

benjie
Copy link
Member

@benjie benjie commented May 17, 2019

  • Use Graphile's LRU cache
  • Dereference more
  • Move first request handler into its own function that can become a noop
  • Reduce number of unnecessary await calls
  • Reduce logic in hot paths
  • Use Object.create(null) to remove the need for Object.hasOwnProperty call
  • Set value to undefined rather than performing delete (JSON.stringify treats both as non-existent)
  • Don't define dynamic functions during each request for requestHandler.then(...) arguments
  • Quick return from pluginHook if no hooks are registered
  • Instrument the pgClient instances once up front rather than checking each time one is grabbed from the pool
  • Add a simplified withAuthenticatedPgClient function to use when no transaction is required (less branching)
  • Remove unnecessary async/await from function that was actually synchronous
  • Environmental variable GRAPHILE_TURBO=1 opts into TypeScript esnext compile target; requires Node v12+ (?)
benjie added 30 commits May 4, 2019
@benjie
Quicker empty check
811492e
@benjie
Save a microtask
de251ac
@benjie
Save another microtask
554bc88
@benjie
delete is expensive
06e2267
@benjie
Only create new object if required
6f5449e
@benjie
Dereference once
a3a6ba5
@benjie
Fix debug usage
5fc69b6
@benjie
Prettier
a801729
@benjie
Debug once up front
ae11052
@benjie
Optimise hook slightly
e5f72fd
@benjie
Declare the right number of arguments
16e1335
@benjie
Compile for Node 12 separately
988d720
@benjie
Use the right pluginHook
3103afa
@benjie
Ignore fastbuild
91b64dc
@benjie
Add pluginHook guards
0900a7e
@benjie
Revert "Add pluginHook guards"
fcca5c0 
This reverts commit d5657c9.

Time taken to run a large number of requests went down from 15.528s to
15.513s. This gain is less than 0.1% so isn't worth the cost.
@benjie
Move first request handler out of request
dcc6f06
@benjie
Reduce hot-path work marginally
e236fc4
@benjie
Async/await not required here
35ec9de
@benjie
Prettier
075d470
@benjie
Lint fixes
4144ff2
@benjie
Going Turbo
7d0cf28
@benjie
Promise fixes
8e3cc95
@benjie
pg-sql2 local dep
e035763
@benjie
Upgrade postgraphile-core
d156c82
@benjie
4.4.1-alpha.0
7f7f3fd
@benjie
Fix entry points
059f2db
@benjie
4.4.1-alpha.1
8aa0b6b
@benjie
Publish build-turbo too
25ae6ab
@benjie
4.4.1-alpha.2
d3a3d30
@benjie benjie merged commit d237417 into master May 17, 2019
4 checks passed
@benjie benjie deleted the perf branch May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@benjie