The Wayback Machine - https://web.archive.org/web/20220323063359/https://github.com/vuejs/vue-router/issues/2550
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn about root paths without a leading slash #2550

Closed
MatiasOlivera opened this issue Dec 24, 2018 · 3 comments · Fixed by #2591, mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, drakeg/udemy_django_vue#14 or tghelere/valorize-vidas#4
Closed

warn about root paths without a leading slash #2550

MatiasOlivera opened this issue Dec 24, 2018 · 3 comments · Fixed by #2591, mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, drakeg/udemy_django_vue#14 or tghelere/valorize-vidas#4
Labels
feature request good first issue has PR
Projects
Longterm

Comments

@MatiasOlivera
Copy link

@MatiasOlivera MatiasOlivera commented Dec 24, 2018 •
edited

Version

2.5.3

Reproduction link

https://codesandbox.io/s/6zvmx5lorr

Example

import Vue from "vue";
import Router from "vue-router";

import Home from "../src/views/Home.vue";
import Products from "../src/views/Products.vue";

Vue.use(Router);

const routes = [
  { name: "home", path: "/", component: Home },
  {
    name: "products",
    path: "products", // <-- the problem is here
    component: Products
  }
];

export default new Router({
  routes
});

Steps to reproduce

  1. Open the reproduction
  2. Click on the products link

What is expected?

I spent some time trying to understand what the problem was, so it would be nice to see a warning message telling that the route is invalid because doesn't have the initial slash.

What is actually happening?

The router goes to a route that doesn't exist.
@posva posva changed the title Path without slash warn about root paths without a leading slash Dec 24, 2018
@Zarad1993
Copy link

@Zarad1993 Zarad1993 commented Dec 28, 2018

Can I work on this?
Sayegh7 added a commit to Sayegh7/vue-router that referenced this issue Jan 22, 2019
@Sayegh7
fix(create-matcher): warn about root paths without a leading slash
b1c178c 
close vuejs#2550
@Sayegh7 Sayegh7 mentioned this issue Jan 22, 2019
Merged
Sayegh7 added a commit to Sayegh7/vue-router that referenced this issue Jan 22, 2019
@Sayegh7
fix(create-route-map): warn about root paths without a leading slash
0416191 
close vuejs#2550
@thedamon
Copy link

@thedamon thedamon commented Feb 5, 2019

Would be nice to see a note in the docs about how slashes should be used in routes.. or did I miss one?
@nmfzone
Copy link

@nmfzone nmfzone commented Mar 11, 2019 •
edited

Any update on this? I think it's should be mentioned in docs if leading slash (in path) is mandatory.
This will make some confusion for new user..
@posva posva added the has PR label Mar 26, 2019
@posva posva added this to Doable or in refactor (low prio, low complex) in Longterm Mar 26, 2019
@posva posva closed this in #2591 Aug 30, 2019
posva added a commit that referenced this issue Aug 30, 2019
@Sayegh7 @posva
feat: warn about root paths without a leading slash (#2591)
7d7e048 
* fix(create-matcher): warn about root paths without a leading slash

close #2550

* fix(create-route-map): warn about root paths without a leading slash

close #2550

* fix(create-route-map): only warn about first route without slash

* fix(create-route-map): handle case of '' route

* fix(create-route-map): remove leftover console.log

* fix(create-route-map): warn about root paths only

* fix(create-route-map): show prettier warning message
@posva posva moved this from Doable or in refactor (low prio, low complex) to Done in Longterm Aug 30, 2019
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Sep 22, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Sep 22, 2019
Open
@snyk-bot snyk-bot mentioned this issue Sep 23, 2019
Open
@snyk-bot snyk-bot mentioned this issue Sep 30, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Oct 1, 2019
Open
@snyk-bot snyk-bot mentioned this issue Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this issue Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this issue Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this issue Dec 7, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Jan 20, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Jan 20, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Jan 21, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Jan 21, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Jan 27, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Feb 5, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Feb 5, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Feb 6, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 6, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Feb 6, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 6, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Feb 6, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Feb 7, 2020
Merged
@tt9133github tt9133github mentioned this issue Feb 14, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 20, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Feb 20, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Feb 21, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Mar 1, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 4, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 10, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 11, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Mar 14, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 19, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 24, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 28, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 6, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Apr 15, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 15, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue has PR
5 participants
@posva @thedamon @nmfzone @MatiasOlivera @Zarad1993