Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClarify dependency install in CONTRIBUTING.rst #1090
Merged
Conversation
The Contributing guide currently directs the user to install Chalice without the optional watchdog dependency, which causes make prcheck to fail. This commit updates the documentation to instruct the user to install this "required" dependency.
codecov-io
commented
Mar 15, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #1090 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 27 27
Lines 4577 4577
Branches 579 579
=======================================
Hits 4370 4370
Misses 135 135
Partials 72 72Continue to review full report at Codecov.
|
|
Good catch, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nkantar commentedMar 15, 2019
Issue #, if available:
Closes #1067
Description of changes:
The Contributing guide currently directs the user to install Chalice without the optional
watchdogdependency, which causesmake prcheckto fail. This PR updates the documentation to instruct the user to install this "required" dependency.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.