The Wayback Machine - https://web.archive.org/web/20220319151449/https://github.com/slackapi/node-slack-sdk/issues/681
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending large message causes misleading error message #681

Closed
4 tasks done
CoreyCole opened this issue Jan 17, 2019 · 5 comments
Closed
4 tasks done

Sending large message causes misleading error message #681

CoreyCole opened this issue Jan 17, 2019 · 5 comments

Comments

@CoreyCole
Copy link

@CoreyCole CoreyCole commented Jan 17, 2019

Description

I opened #680 because I was getting a weird error message and I couldn't figure out why. I was sending a message to one of my slack channels with a large stringified JSON object. When I tried to send it, no message arrived in the slack channel, and my node server got the error from the rtm.sendMessage() promise rejection:

Error: Message sent but no server acknowledgement was recieved. This may be caused by the client changing connection state rather than any issue with the specific message. Check before resending.

After some debugging, I found out the message wasn't sent because the stringified JSON object was too large. Once I deleted off some of the larger sub-objects, the message sent. I'm wondering if we could get a better error message when this is happening.

What type of issue is this? (place an x in one of the [ ])

  • enhancement (feature request)

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

@slack/client version: 4.8.0

node version: 8.12.0

OS version(s): 10.13.6

Steps to reproduce:

  1. create a large JSON object
  2. rtm.sendMessage(JSON.stringify(obj, null, 2))
  3. see above error message and no message sent to the slack channel

Expected result:

An error message stating the provided message to rtm.sendMessage() is too large to be sent.

Actual result:

An error message implying a disconnection from the server.

@aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Jan 17, 2019

Wow, you already made the issue I was thinking of making. Thanks so much!

@misscoded
Copy link
Contributor

@misscoded misscoded commented Sep 11, 2020

This issue needs to be reverified to decide if it's still relevant in the current version.

@github-actions
Copy link

@github-actions github-actions bot commented Dec 5, 2021

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out.

@github-actions
Copy link

@github-actions github-actions bot commented Feb 7, 2022

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.

@github-actions
Copy link

@github-actions github-actions bot commented Feb 21, 2022

As this issue has been inactive for more than one month, we will be closing it. Thank you to all the participants! If you would like to raise a related issue, please create a new issue which includes your specific details and references this issue number.

@github-actions github-actions bot closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment