The Wayback Machine - https://web.archive.org/web/20201013072156/https://github.com/reactjs/react-rails/issues/948
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On certain JS runtimes, send warning notice. #948

Open
BookOfGreg opened this issue Oct 19, 2018 · 1 comment · May be fixed by #949
Open

On certain JS runtimes, send warning notice. #948

BookOfGreg opened this issue Oct 19, 2018 · 1 comment · May be fixed by #949

Comments

@BookOfGreg
Copy link
Member

@BookOfGreg BookOfGreg commented Oct 19, 2018

Related to #947 and any other issue mentioning Set, Node < 6 or RubyRacer.

All of those issues are due to old JS runtimes.
I would welcome a PR that detects invalid JS runtimes and warns the user to update system Node or use a libv8 gem that is up to date.

Relates to rubygems/rubygems#1811 as having miniracer be an optional dependency would aid this effort.

I would also welcome a PR that updates the readme to document the JS runtimes.

@HeroProtagonist
Copy link

@HeroProtagonist HeroProtagonist commented Oct 20, 2018

Hi! I can take look at this. PR to come

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.