Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updocker stop showing 'errors' in runtime log #467
Comments
|
@grahamwhaley -- I see the same thing when doing:
This is a bit concerning, especially given some of the other life cycle bugs we have open. |
|
Closing as this isn't a bug in the runtime, it's a bug in containerd afaik: And here's the relevant snippets from a debug log showing how the runtime was called for a single container lifecycle:
|
|
So @jodh-intel , should we be changing our error to a warning, to match cc-oci-runtime better (and cause less concerning messages in the logs) ? |
|
It's very debatable. The runtime has detected that it has been called incorrectly, so that is an error. I'm easy either way though as long as we log at atleast the warning level. |
|
OK, after irc chatter and input from @egernst I'm going to re-open this asking that we downgrade those errors to info/warnings - given that the double delete is, I believe, benign, correct @jodh-intel ? |
|
It's benign in that the runtime catches the incorrect call from |
Once `containerID` and `sandboxID` fields are available, re-register the logger with the external packages to ensure they too display these important fields. Fixes clearcontainers#467. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Distro: Ubuntu 16.04.2 LTS server
cc-runtime: 3.0.0-beta1 (from OBS install)
Running:
where
XXXXXXis the container ID from the first step, is producing two errors for me in the runtime log (that I enabled by uncommenting the relevant section of the /etc... config file):The ID there matches the XXXXXX above.
afaict, the error lines appear during the
docker rmphase - but, I am not wholly convinced that is right.I would post the whole/rest of the relevant bits of the log, but it is about 800 long lines, so perhaps I'll not do that yet.