The Wayback Machine - https://web.archive.org/web/20201107012849/https://github.com/google/go-cloud/issues/1710
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/rabbitpubsub: godocs mention AMQP but never explain relationship #1710

Closed
zombiezen opened this issue Mar 28, 2019 · 0 comments
Closed

pubsub/rabbitpubsub: godocs mention AMQP but never explain relationship #1710

zombiezen opened this issue Mar 28, 2019 · 0 comments

Comments

@zombiezen
Copy link
Contributor

@zombiezen zombiezen commented Mar 28, 2019

Is your feature request related to a problem? Please describe.

As a casual Pub/Sub observer, I have heard of the product "RabbitMQ" but hadn't really heard of "AMQP" until working on this project. When writing the how-to guides for Pub/Sub (#1576), I discovered that the rabbitpubsub constructors all require the caller to create an AMQP connection. My concern is that without having additional context in the reference, it will not make sense that someone has to provide a connection string for their RabbitMQ server to create an AMQP connection.

Describe the solution you'd like

I'd like the godocs for the rabbitpubsub package to mention AMQP in the description and draw the link more explicitly. In the how-to guides, I link to https://www.rabbitmq.com/protocol.html to give more context and mention that AMQP 0.9.1 is the dialect that RabbitMQ communicates with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.