The Wayback Machine - https://web.archive.org/web/20201228152015/https://github.com/grych/drab/issues/93
Skip to content

/ drab

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers `messagebox`, `confirm` and `prompt` to Drab.Browser #93

Open
grych opened this issue Apr 3, 2018 · 7 comments
Open

Add helpers `messagebox`, `confirm` and `prompt` to Drab.Browser #93

grych opened this issue Apr 3, 2018 · 7 comments
Labels
enhancement help wanted level:starter

Comments

@grych
Copy link
Owner

@grych grych commented Apr 3, 2018 •
edited

This is a good, easy entry point to contribute!
@grych
Copy link
Owner Author

@grych grych commented Apr 3, 2018

With timeout: :infinity
@grych grych changed the title Add helpers `alert` and `confirm` to Drab.Browser Add helpers `alert`, `confirm` and `prompt` to Drab.Browser Apr 3, 2018
@grych grych changed the title Add helpers `alert`, `confirm` and `prompt` to Drab.Browser Add helpers `messagebox`, `confirm` and `prompt` to Drab.Browser Jul 24, 2018
@richardvdveen
Copy link

@richardvdveen richardvdveen commented Oct 20, 2018

@grych I would like to contribute and help resolve this issue, could you provide more context on the helpers?
@grych
Copy link
Owner Author

@grych grych commented Oct 21, 2018 •
edited

HI @Blackjaguar18, appreciated!
this is a simple wrapper around javascript alert, confirm and prompt. Please name function calling JS alert - messagebox/3, as it should not be confused with Drab.Modal.alert.
Functions should return what JS returns, so messagebox will return "undefined", confirm - boolean and prompt - string.

Please create pair of each of the functions, normal and bang - as it is done for the other functions in Drab.Modal.

Please use timeout: :infinite as default option in exec_js - we want to hold on processing while displaying an alert. Of course timeout should be overritable.
@nikhilmore54
Copy link

@nikhilmore54 nikhilmore54 commented Apr 11, 2019

What is the status of this issue?
@grych
Copy link
Owner Author

@grych grych commented Apr 12, 2019

Hi @nikhilmore54, it is not finished yest
@nikhilmore54
Copy link

@nikhilmore54 nikhilmore54 commented Apr 12, 2019

@grych
Copy link
Owner Author

@grych grych commented Apr 12, 2019

Hi @nikhilmore54, appreciated!

"this is a simple wrapper around javascript alert, confirm and prompt. Please name function calling JS alert - messagebox/3, as it should not be confused with Drab.Modal.alert.
Functions should return what JS returns, so messagebox will return "undefined", confirm - boolean and prompt - string.

Please create pair of each of the functions, normal and bang - as it is done for the other functions in Drab.Modal.

Please use timeout: :infinite as default option in exec_js - we want to hold on processing while displaying an alert. Of course timeout should be overritable."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted level:starter
3 participants
@grych @nikhilmore54 @richardvdveen
You can’t perform that action at this time.