Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild.py default output path has changed #1929
Closed
Comments
asmirsabanovic
changed the title
|
Because the demo app is built on top of the new Shaka Player UI, the default build has changed to the UI build in python build/build.py +@complete -@dash -@ui --name compiled --force |
joeyparrish
changed the title
|
It works now, thanks for the help and quick feedback! It might be a good idea to update the docs for v2.5.0: https://github.com/google/shaka-player/blob/master/build/README.md |
|
Yes! Thanks for pointing that out. I'll reopen this issue until we've corrected the docs. |
TheModMaker
added a commit
that referenced
this issue
Jul 3, 2019
AnteWall
added a commit
to AnteWall/shaka-player
that referenced
this issue
Jul 17, 2019
Closes google#1929 Change-Id: Ie3a15ba3928ca21f9f4eb5c8ff423e2b5875782c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
2.5.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
master?Yes
Are you using the demo app or your own custom app?
custom app
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Chrome (74.0.3729.131), OSX 10.14.2 (18C54)
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd
What did you do?
Run
python build/build.py +@complete -@dash --forceWhat did you expect to happen?
dist/shaka-player.compiled.jsto be built without dash supportWhat actually happened?
It was built with dash support and I could play a dash manifest. This used to work when I was using v2.4.7