The Wayback Machine - https://web.archive.org/web/20200524045319/https://github.com/docker/kitematic/issues/3658
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress circle should use fixed-width digit font #3658

Open
rillig opened this issue Mar 16, 2018 · 5 comments
Open

Progress circle should use fixed-width digit font #3658

rillig opened this issue Mar 16, 2018 · 5 comments

Comments

@rillig
Copy link

@rillig rillig commented Mar 16, 2018

image

Expected behavior

During "Starting Docker VM", the progress is visualized in a circle. When the percentage changes from 60 to 61, the percentage character should stay in place, to avoid any flickering appearance. Same for the 6, which also didn't change.

Actual behavior

The whole string %d%% is centered, therefore the 6 and the % each jump by a few pixels. This makes the screen more nervous than necessary.

Workaround (for developers)

If using a font with fixed-width digits is not possible, it would help to draw each digit individually in this case, reserving the maximum necessary width for each digit.

@FrenchBen
Copy link
Contributor

@FrenchBen FrenchBen commented Mar 16, 2018

@rillig Thanks for the issue and your attention to detail - Is this something you'd consider opening a PR for?

@rillig
Copy link
Author

@rillig rillig commented Mar 16, 2018

Yes, I definitely and intentionally considered opening a PR for this.

Kitematic has a minimalistic UI, in which each non-white pixel has its purpose. Therefore, when some of these pixels flicker, they make me look at them, only to discover that nothing essential has changed. Whether the progress is at 60% or at 61% doesn't really matter, nevertheless some more pixels changed their color.

This contradicts the quiet and unobtrusive style and design that Kitematic is using.

A recent blog article has some nice screen videos of other applications showing the same behavior.

@shandheap
Copy link

@shandheap shandheap commented Jun 3, 2018

Hey @rillig, are you still working on this? If not, I'd like to work on this issue for my first PR.

@rillig
Copy link
Author

@rillig rillig commented Jun 3, 2018

Hi @shandheap, I have never "worked" on this. I just reported it in the hope that it would be fixed someday.

@shandheap
Copy link

@shandheap shandheap commented Jun 10, 2018

Hey @rillig, I just wanted to ask just in case you opened a PR for it. I couldn't reproduce this issue on my machine anyway so I'm guessing it's fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.