Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 36 million developers.
Sign up
Pinned
458 contributions in the last year
Activity overview
Contributed to
ampproject/amphtml,
google/github-owners-bot,
erwinmombay/amphtml
and 5 other
repositories
Contribution activity
June 1, 2019
erwinmombay has no activity
yet for this period.
May 2019
- erwinmombay/amp-github-apps JavaScript
Created a pull request in ampproject/amphtml that received 7 comments
repace version() calls with the version string literal
for some reason these calls aren't dce'd into the string literal
+143
−42
•
7
comments
- 🐛 Enable type checking for `3p/environment.js`
- Re-enable amp-mustache-0.1 integration tests
- 🏗Extract and indirect log message string
- 🏗 Add a check for the default `gulp` executable path
- 🏗♻️🚮🐛 Refactor `compile()` in `build-system/tasks/helpers.js`
- ✨ Support dynamically added lists and add configuration options
- 🏗 End e2e task with grace
- 🏗🐛 Rename `version` to `internalRuntimeVersion` in AmpPass.java
- 🏗🚮 Use `compiler.jar` instead of `runner.jar` for single pass, remove unnecessary code
- Disable flaky visual diff test "amp-accordion: page loads"
- 🏗♻️Refactor `compileJs` into smaller functions
- 🏗🚮🐛 Assorted `gulp` compilation fixes
- 🏗✨Upgrade to `gulp` v4 and migrate all tasks to the new API
- Add a template for release tracking issues
- Add --custom_version_mark to build jobs to set a custom last digit to the RTV number
- add plugin transformer to AMP.extension call for singlepass
Created an issue in ampproject/amphtml that received 4 comments
[maybe] add platform specific classes amp-dynamic-css-classes
This will allow a user to hide/show platform specific section, or platform specific stylings by targeting the top level class added to the body (isIOS
4
comments