The Wayback Machine - https://web.archive.org/web/20220709183525/https://github.com/github/gh-ost/commits
Skip to content
Permalink
master
Switch branches/tags

Commits on Jul 8, 2022

  1. Merge pull request #1147 from timvaillancourt/rm-go-os-process-go

    Remove unused `go/os/process.go`
    dm-2 committed Jul 8, 2022
  2. Merge pull request #1134 from github/changelog-migrated-state

    Add `Migrated` changelog event state
    dm-2 committed Jul 8, 2022

Commits on Jul 7, 2022

  1. Merge pull request #1146 from github/switch-to-term-package

    Switch to golang.org/x/term; go mod vendor
    dm-2 committed Jul 7, 2022
  2. Fix lint

    timvaillancourt committed Jul 7, 2022
  3. switch to golang.org/x/term from deprecated golang.org/x/crypto/ssh/t…

    …erminal module; go mod vendor
    dm-2 committed Jul 7, 2022
  4. Merge pull request #1145 from timvaillancourt/golang-ci-staticcheck-l…

    …inter
    
    `golang-ci`: enable/fix `staticcheck` lint warnings
    dm-2 committed Jul 7, 2022
  5. Merge pull request #1138 from github/changlog-table-comment

    Changlog table comment
    dm-2 committed Jul 7, 2022
  6. Merge pull request #1137 from github/go-mysql-binlog-dead-code

    Remove unused code in `go/mysql/binlog.go`
    dm-2 committed Jul 7, 2022
  7. cleanup v5

    timvaillancourt committed Jul 7, 2022
  8. cleanup v4

    timvaillancourt committed Jul 7, 2022
  9. cleanup v3

    timvaillancourt committed Jul 7, 2022
  10. cleanup v2

    timvaillancourt committed Jul 7, 2022
  11. Cleanup

    timvaillancourt committed Jul 7, 2022

Commits on Jul 6, 2022

  1. Cancel any row count queries before attempting to cut over (#846)

    * Cancel any row count queries before attempting to cut over
    
    Closes #830. Switches from using `QueryRow` to `QueryRowContext`, and
    stores a context.CancelFunc in the migration context, which is called to
    halt any running row count query before beginning the cut over.
    
    * Make it threadsafe
    
    * Kill the count query on the database side as well
    
    * Explicitly grab a connection to run the count, store its connection id
    * When the query context is canceled, run a `KILL QUERY ?` on that connection id
    
    * Rewrite these to use the threadsafe functions, stop exporting the cancel func
    
    * Update logger
    
    * Update logger
    
    Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
    Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
    Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
    4 people committed Jul 6, 2022
  2. Default to go1.17.11 (#1136)

    * Default to go1.17.11
    
    * `go mod vendor`
    
    Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
    timvaillancourt and dm-2 committed Jul 6, 2022
  3. Add context/timeout to HTTP throttle check (#1131)

    * Add context/timeout to HTTP throttle check
    
    * Dont run `.GetThrottleHTTPInterval()` on every loop
    
    * Update help message
    
    * Var rename
    
    * 2022
    
    * Add timeout flag
    
    * Add unix/tcp server commands, use ParseInt() for string->int64
    
    * Var rename
    
    * Re-check http timeout on every loop iteration
    
    * Remove stale comment
    
    * Make throttle interval idempotent
    
    * var rename
    
    * Usage grammar
    
    * Make http timeout idempotent too
    
    * Parse time.Duration once
    
    * Move timeout to NewThrottler
    
    * Help update
    
    * Set User-Agent header
    
    * Re-add newline
    
    Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
    timvaillancourt and dm-2 committed Jul 6, 2022
  4. Use switch statements for readability, simplify `.NewGoMySQLReader(…

    …)` (#1135)
    
    * Use `switch` statements for readability
    
    * Simplify initBinlogReader()
    timvaillancourt committed Jul 6, 2022
  5. Ensure mysql rows responses are closed (#1132)

    Co-authored-by: dm-2 <45519614+dm-2@users.noreply.github.com>
    timvaillancourt and dm-2 committed Jul 6, 2022
  6. compound pk tests (#387)

    * compound pk tests
    
    * more details in failure diff
    
    * more elaborate test; the pk-ts one consistently fails
    
    * Fix merge conflict
    
    Co-authored-by: Shlomi Noach <shlomi-noach@github.com>
    Co-authored-by: Tim Vaillancourt <timvaillancourt@github.com>
    Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
    4 people committed Jul 6, 2022
  7. Merge pull request #1140 from timvaillancourt/fix-issue-1117

    Fix `integer divide by zero` panic in migrator
    dm-2 committed Jul 6, 2022
  8. Merge pull request #1141 from shaohk/fix-two-phase-commit-lost-data_v2

    fix(lost data in mysql two-phase commit): lost data in mysql two-phas…
    dm-2 committed Jul 6, 2022
Older