The Wayback Machine - https://web.archive.org/web/20201215230750/https://github.com/sendgrid/sendgrid-csharp/pull/719
Skip to content

/ sendgrid-csharp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update travis config to use relative path #719

Merged
merged 1 commit into from Aug 21, 2018
Merged

Update travis config to use relative path #719

merged 1 commit into from Aug 21, 2018

Conversation

@siburny
Copy link
Contributor

@siburny siburny commented Aug 10, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This PR fixes hard-coded full path in the travis build file. When someone works with the forked repository, travis builds always fail because of that.
@siburny
Update travis config to use relative path
Loading status checks…
7abd604
@SendGridDX
Copy link

@SendGridDX SendGridDX commented Aug 10, 2018 •
edited

CLA assistant check
All committers have signed the CLA.
@siburny siburny closed this Aug 13, 2018
@siburny siburny reopened this Aug 13, 2018
@siburny
Copy link
Contributor Author

@siburny siburny commented Aug 13, 2018

Rebuilding travis
@thinkingserious thinkingserious merged commit 00e543d into sendgrid:master Aug 21, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@thinkingserious
Copy link
Contributor

@thinkingserious thinkingserious commented Aug 21, 2018

Hello @siburny,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX
@siburny siburny deleted the siburny:update-travis-build-path branch Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy status: code review request type: sendgrid enhancement
4 participants
@siburny @SendGridDX @thinkingserious @jpurpura
You can’t perform that action at this time.