The Wayback Machine - https://web.archive.org/web/20201202105619/https://github.com/aviacommerce/avia/pull/276
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import product from Etsy #276

Merged
merged 8 commits into from Nov 27, 2018
Merged

Import product from Etsy #276

merged 8 commits into from Nov 27, 2018

Conversation

@SagarKarwande
Copy link
Member

@SagarKarwande SagarKarwande commented Oct 17, 2018

Add feature to import product from Etsy shop.

Motivation and Context

As a store owner, it should be easy to import product from other stores to Avia.

Describe your changes

Pending tasks

  • Add check for the already imported listing
  • Make product import function atomic
  • Stock import for listing
  • Add default taxonomy before import start
  • Disable Etsy import button if already import is running.
  • Check store is already authorized for import and start import immediately
  • Delete downloaded images generated while import.
  • Retry strategy for Background importer.
  • Generate imported product slug from name
  • Handle different store setting currency and imported product currency

Checklist

  • I have read CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code does not generate any (new) credo and compile-time warnings.
  • I have updated the documentation wherever necessary.
  • I have added tests to cover my changes.
  • Handle case where user should not be Autorized from Etsy multiple times.

Dear Gatekeeper,

Please make sure that the commits that will be merged or rebased into the base
branch are formatted according to our standards.

The only additional requirement is that the the PR number must appear in the
commit title in brackets: (#XXX)

@SagarKarwande SagarKarwande added the WIP label Oct 17, 2018
@SagarKarwande SagarKarwande self-assigned this Oct 17, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 17, 2018

Codecov Report

Merging #276 into develop will decrease coverage by 0.45%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #276      +/-   ##
===========================================
- Coverage     63.9%   63.44%   -0.46%     
===========================================
  Files          126      128       +2     
  Lines         1388     1398      +10     
===========================================
  Hits           887      887              
- Misses         501      511      +10
Impacted Files Coverage Δ
...ps/snitch_core/lib/core/data/schema/store_props.ex 0% <0%> (ø)
...pps/snitch_core/lib/core/data/model/store_props.ex 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1adcd...b4ae0a0. Read the comment docs.

@ashish173 ashish173 removed the WIP label Oct 24, 2018
@ashish173 ashish173 self-requested a review Oct 27, 2018
@SagarKarwande SagarKarwande force-pushed the import-products branch from 8d3b2f4 to 02d5774 Nov 14, 2018
@SagarKarwande SagarKarwande force-pushed the import-products branch from 4afd7ba to 2a191c4 Nov 26, 2018
@codecov
Copy link

@codecov codecov bot commented Nov 26, 2018

Codecov Report

No coverage uploaded for pull request base (develop@6e2be84). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #276   +/-   ##
==========================================
  Coverage           ?   67.06%           
==========================================
  Files              ?      134           
  Lines              ?     1497           
  Branches           ?        0           
==========================================
  Hits               ?     1004           
  Misses             ?      493           
  Partials           ?        0
Impacted Files Coverage Δ
apps/snitch_core/lib/core/data/schema/product.ex 82.6% <ø> (ø)
...ps/snitch_core/lib/core/data/schema/store_props.ex 0% <0%> (ø)
...pps/snitch_core/lib/core/data/model/store_props.ex 0% <0%> (ø)
...s/snitch_core/lib/core/domain/taxonomy/taxonomy.ex 12.28% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2be84...bc8b64f. Read the comment docs.

@ashish173 ashish173 merged commit c3bf451 into develop Nov 27, 2018
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/changes Unable to determine changes, no report found at pull request base.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
@ashish173 ashish173 deleted the import-products branch Nov 27, 2018
ashish173 added a commit that referenced this pull request Jan 1, 2019
Now users can import Etsy products from etsy stores.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.