This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Implement dragging and dropping from OS file explorer #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Under Ubuntu 15.04
|
|
I was getting the same error on OS X El Capitan, and this PR fixes it |
|
Has this been looked at at all? |
|
@Zireael07 Thanks for the nudge! It hasn't been reviewed yet but I'll try to get to it this week. |
| @@ -832,11 +832,15 @@ class TreeView extends View | |||
| entry = e.currentTarget | |||
| return unless entry instanceof DirectoryView | |||
|
|
|||
| initialPath = e.originalEvent.dataTransfer.getData("initialPath") | |||
There was a problem hiding this comment.
It seems preferable to keep this, rather than looking it up twice below.
|
Just one comment. Otherwise this looks good 👍 |
|
@joshaber Good to go pending CI |
|
Seems to work as advertised. Thanks @Tyriar! |
joshaber
added a commit
that referenced
this pull request
Jan 15, 2016
Implement dragging and dropping from OS file explorer
|
macos 10.12: Error while dropping file from an external volume. EXDEV: cross-device link not permitted, rename '/Volumes/SomeFatHarddisk/spot1/banner_large.png' -> '/Users/dude/Documents/myproject/www/img/banner_large.png' |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #570