Add feature: toggle on/off

[roccosportal]

I added the feature 'Toggle' to the 'Packages -> Spell Check' menu. I had a look at https://github.com/fundon/atom-minimap for the implemenation. A review would be nice, since I'm new to atom and not very good in coffeescript.

[kevinsawicki]

Are you trying to enable/disable for a given editor or all editors? Seems the current implementation affects all editors.

I would think it would be more useful to opt-in/out a specific editor. If you want to disable to all editors it probably just makes sense to deactivate the package completely.

[roccosportal]

The current implementation enable/disable the plugin for all editor. It is meant as a short hand instead of going to Preferences, searching the plugin and then disable it. Also next start the plugin ist activated again.

In my case I want to have a quick way to disable spell check for a project which has German text files.

In both ways (all editors/one editor) my case would be solved, but the latter one seems more reasonable. I only copied the code from 'atom-minimap' (disable all editors) and I don't now (yet) how to implement it.

[roccosportal]

The implementation was actually quite easy!

[acrogenesis]

👍 for this

[karlek]

Any update on this?

[pwaller]

Ping. I just wanted to edit a tech document document and everything has been highlighted. It's very distracting and I want to turn it off.

[roccosportal]

Well I updated the code. Merging is off my hands.

[thedaniel]

This still needs a spec, then it can be merged.

[roccosportal]

"spec" stands for specification? I'm not sure what you mean. Any references how the specification should look like? We are talking about a toggle on/off feature, what should I specify? Thanks!

[50Wliu]

@roccosportal a "spec" is something that tests this behavior to make sure it doesn't break in the future. See the specs folder for some examples and the specs styleguide for more pointers.

[roccosportal]

Alright, I will look into it. But I'm going on vacation now, anyone feel free to write a spec.

[maxcnunes]

Hi,

This is a pretty useful feature. Good job @roccosportal!! I'm trying to create the tests for it.
I'm just confused how to apply my changes to this pull request. Do I have to send the pull request to roccosportal/spell-check:master?

[maxcnunes]

I sent the test to @roccosportal's fork. That seems the right approach. But since he is on vocation I'm not sure he is going to be able merging it soon.

[maxcnunes]

@kevinsawicki any plan merging it to master?

[jehrhardt]

@roccosportal: There are some conflicts that need to be resolved before merge.

Btw. great work 👍.

[roccosportal]

Did the merge and updated the toggle off spec.

[jehrhardt]

@kevinsawicki Is there anything to do before this can be merged?

[thedaniel]

This looks great. I think that @subscriptionsOfCommands should be @commandSubscriptions but in the interest of diminishing back-and-forth, I'll just change that in a separate PR.

[0mp]

When will this feature be available in Atom? I cannot find it.

[thedaniel]

It's only just made it into the Atom 1.7 beta release, which will probably become stable in a few weeks, but there's no set release date.

[lattatude]

I'm still not seeing this available in Atom 1.11.2

[0mp]

@xenomode Click Packages > Command Palette > Toggle and search for Spell Check: Toggle.