Speed up spell checking #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
force-pushed
the
mb-use-bulk-spell-checking-method
branch
from
0b4d35d
to
7bee024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Runaway background task
This is fixed by atom/node-spellchecker#27. See that PR for details
UI Unresponsiveness
This is partially improved by doing less work for each misspelling marker. We now put the misspelling markers in their own marker layer so that they can be decorated and destroyed in a batch (similar to https://github.com/atom/find-and-replace/pull/588/files).
There is still noticable lag when editing large files, due to the cost of recreating all of the spell-check markers. We may want to move toward re-checking changed parts of the buffer in the UI process, rather than re-checking the entire buffer in a background process. This would be very similar to how we re-scan regions of the buffer in
find-and-replace.