The Wayback Machine - https://web.archive.org/web/20220223133658/https://github.com/atom/settings-view/pull/748
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaults on focus #748

Merged
merged 2 commits into from Mar 16, 2016
Merged

Add defaults on focus #748

merged 2 commits into from Mar 16, 2016

Conversation

@fvantienen
Copy link
Contributor

@fvantienen fvantienen commented Mar 13, 2016

Add defaults on focus and remove them when input field contains the default.
This should fix #243.
@amytruong
Copy link

@amytruong amytruong commented Mar 15, 2016

Took a quick look and tested per @lee-dohm's request (windows and mac) and it looks good on my end so far. 🎉
@lee-dohm lee-dohm added the atom label Mar 15, 2016
@joshaber joshaber self-assigned this Mar 16, 2016
@joshaber
Copy link
Contributor

@joshaber joshaber commented Mar 16, 2016

Looks good, thanks @fvantienen!
joshaber added a commit that referenced this issue Mar 16, 2016
@joshaber
Merge pull request #748 from delftswa2016/defaults_editable
e9ac721 
Add defaults on focus
@joshaber joshaber merged commit e9ac721 into atom:master Mar 16, 2016
1 check passed
@stefansundin
Copy link

@stefansundin stefansundin commented May 8, 2016

Hey all, I am pretty sure this broke setting "0" for integer values.

In isDefault:

not value or defaultValue is value

The not value part is true if value=0.

Apologies if something else did it, but it's broken alright. Let me know if you want me to open a new issue for it.
@Arcanemagus Arcanemagus mentioned this pull request May 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atom needs-review
6 participants
@fvantienen @amytruong @joshaber @stefansundin @lee-dohm @50Wliu