Replace spinner #88
Replace spinner #88
Conversation
with a hardware accelerated spinner that doesn't cause repaints.
|
Last reference to the Octocat gone from Atom New throbber looks great. |
|
Octoface is still in Welcome.
|
|
There seems to be a need for additional tuning of the animation. Possibly some serious rounding issues at play. At least there are some very visible problems with how the animation is currently defined/implemented. For instance, look at the base of the hands with respect to the center of the watch face鈥攖hey are not fixed, and at times there's a very visible spacing between the hands near the center (the anchor point or whatever one might call it). Don't get me wrong, I like the new spinner, but it does need to be tuned/fixed. |
Hehe.. yeah, that "wiggly" is intentional. Wanted to try something new and make it a bit more "playful". But I was worried that it might look like an "error" or so. Which your observation confirms. @thomasjo Thanks for pointing that out. Ok, I removed it again. Now the center stays fixed:
On a second thought. Having a "clock" as spinner might not be that ideal. "Clocks" might have some negative feelings attached.. as in "having to wait". Hmm.. |
Likely extremely difficult to achieve, but an animated "atom" (based on the Atom app icon) would be amaze |
That seems like a pretty interesting challenge :) |
That would be super cool. I think as an SVG graphic, you could animate the strokes. But probably needs repainting for every frame. If not as a spinner, we should def try to do it for the logo in the Welcome or so. Anyways.. changed it to a
|
|
Ok, gonna merge this for now. Until we have some kind of Atom spinner. |
since `.loading` get's used in other contexts and not just for the spinner. Part of #88
since `.loading` get's used in other contexts and not just for the spinner. Part of atom/one-dark-ui#88
|
This is the first thing I noticed from 1.4.0, good work guys! |
|
I'm going to get to work on an atom spinner. No guarantees, though, pure css atoms might not work (because there's just :before and :after to work with) |
|
Ok, so I've got all the orbitals built. I don't think there's a way for me to add the actual atom's core, though... Once that's in, however, adding orbitals would be easy. |
Maybe it could be a radial gradient as background. But might be tricky to not animate it with the rest.
That would be neat. I think you can animate strokes in SVG. So that it would look like the electron lines are circling around. Although it probably has some performance impact because it needs to repaint all the time. |
|
@simurai: That's a great idea! However, you can't apply a box-shadow to a radial gradient, and that's how I was planning to add the electrons... Any animation that doesn't involve changing box-shadows will involve rotating the paths, which would completely break the way I'm hiding parts of the paths. |
|
Actually, it's possible to animate a gradient, and if a simple "thickening" of the line is enough, then the gradient should suffice for this purpose. |
Before:
After:
Benefits:
Although R.I.P.
馃槩