The Wayback Machine - https://web.archive.org/web/20201202024944/https://github.com/atom/one-dark-syntax/pull/61
Skip to content
This repository has been archived by the owner. It is now read-only.

Highlight keyword operators, fixed #44 #61

Merged
merged 1 commit into from Feb 4, 2016
Merged

Conversation

@livelazily
Copy link
Contributor

@livelazily livelazily commented Jan 16, 2016

No description provided.

@simurai
Copy link
Member

@simurai simurai commented Feb 4, 2016

@livelazily Thanks.

Before:

screen shot 2016-02-04 at 10 42 36 am

After:

screen shot 2016-02-04 at 10 42 19 am

  1. The javascript.less file needs to be imported from index.less, maybe after java.less: https://github.com/atom/one-dark-syntax/blob/master/index.less#L13
  2. Wow.. That Less code is so advanced.. 😳 Would you be ok to write it a bit simpler? Maybe something like this:
.source.js {
  .keyword.operator {
    &.delete,
    &.in,
    &.of,
    &.instanceof,
    &.new,
    &.typeof,
    &.void {
      color: @syntax-color-keyword;
    }
  }
}

It is less elegant, but maybe easier to understand for normal people.

@livelazily
Copy link
Contributor Author

@livelazily livelazily commented Feb 4, 2016

@simurai Please review again.

@50Wliu
Copy link
Member

@50Wliu 50Wliu commented Feb 4, 2016

Perhaps the "regular" operators should also receive a different color to help them stand out?

@livelazily
Copy link
Contributor Author

@livelazily livelazily commented Feb 4, 2016

@simurai
Copy link
Member

@simurai simurai commented Feb 4, 2016

Perhaps the "regular" operators should also receive a different color to help them stand out?

Here the same example from #44:

Before:

screen shot 2015-12-06 at 2 20 22 pm

Only keywords (this PR)

screen shot 2016-02-04 at 11 23 48 am

All operators:

screen shot 2015-12-06 at 2 03 25 pm

What do you think? I'm open to both, but if I would have to pick, it's "Only keywords". Colored = just feels a bit too much.

@50Wliu
Copy link
Member

@50Wliu 50Wliu commented Feb 4, 2016

I was actually suggesting a different color than purple (blue? green? I don't know) - not sure if that's feasible or not though with the base16 palette.

@simurai
Copy link
Member

@simurai simurai commented Feb 4, 2016

cyan? Since it's close to the neutral grey, but still a little color.

screen shot 2016-02-04 at 11 39 36 am

@simurai
Copy link
Member

@simurai simurai commented Feb 4, 2016

Ok, let's merge this and I'll add the cyan after.

@livelazily thanks for the PR.

simurai added a commit that referenced this pull request Feb 4, 2016
Highlight keyword operators, fixed #44
@simurai simurai merged commit 8fa750c into atom:master Feb 4, 2016
simurai added a commit that referenced this pull request Feb 4, 2016
simurai added a commit to atom/one-light-syntax that referenced this pull request Feb 4, 2016
@simurai simurai mentioned this pull request Feb 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.