The Wayback Machine - https://web.archive.org/web/20221207052646/https://github.com/atom/language-python/pull/126
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More debuggers #126

Merged
merged 3 commits into from Jan 6, 2016
Merged

More debuggers #126

merged 3 commits into from Jan 6, 2016

Conversation

jrial
Copy link
Contributor

@jrial jrial commented Jan 6, 2016

Added two more debuggers:

@jrial
Copy link
Contributor Author

jrial commented Jan 6, 2016

Note that these snippets don't put extra newlines after the inserted text, to maintain consistency with the rest of the snippets. However, this behaviour was not followed by the original pdb and ipdb snippets, so a separate PR #125 was submitted to fix that.

@50Wliu
Copy link
Member

50Wliu commented Jan 6, 2016

Hi @jrial, can you please rebase this on master now that #125 was merged? Thanks!

@jrial
Copy link
Contributor Author

jrial commented Jan 6, 2016

@50Wliu Done, do I close this PR and create a new one from master now?

Not entirely sure of the proper PR workflow on GH nor why it's a problem that this is on a topic branch. Feel free to enlighten me.

@50Wliu
Copy link
Member

50Wliu commented Jan 6, 2016

Hmm, I asked because the newline changes are still showing up here even though they were already included in master. Nothing else is wrong with the PR itself or your workflow :).

'iPDB set trace':
'prefix': 'ipdb'
'body': 'import ipdb; ipdb.set_trace()\n'
'body': 'import ipdb; ipdb.set_trace()'
'rPDB set trace - ':
Copy link
Member

@50Wliu 50Wliu Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a dash (-) following this snippet and the PuDB one?

Copy link
Contributor Author

@jrial jrial Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on on that merge, seems I committed mid-work. I'll commit the rest as soon as I get home.

@jrial
Copy link
Contributor Author

jrial commented Jan 6, 2016

Trailing dashes removed. I wanted to include a little sentence describing the difference between various debuggers, but decided against it. It would make the text too long, and people can use Google if necessary.

50Wliu added a commit that referenced this pull request Jan 6, 2016
@50Wliu 50Wliu merged commit d4dbd19 into atom:master Jan 6, 2016
@50Wliu
Copy link
Member

50Wliu commented Jan 6, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants