Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Improve regexp highlighting #58
Merged
Conversation
|
Looks good to me |
| @@ -637,7 +637,7 @@ | |||
| ] | |||
| } | |||
| { | |||
| 'begin': '(?<=\\(|\\{|~|&)\\s*((\\/))' | |||
| 'begin': '(?<=\\(|\\{|~|&|\\||if|unless|^)\\s*((\\/))' | |||
50Wliu
Dec 1, 2015
Member
This is obviously something really small and definitely doesn't need to block this PR, but the curly bracket { doesn't need to be escaped. Also, I think ^ is usually placed at the beginning of the match.
This is obviously something really small and definitely doesn't need to block this PR, but the curly bracket { doesn't need to be escaped. Also, I think ^ is usually placed at the beginning of the match.
kevinsawicki
added a commit
that referenced
this pull request
Dec 4, 2015
Improve regexp highlighting
|
Thanks for this @Fank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #53