The Wayback Machine - https://web.archive.org/web/20240823075057/https://github.com/atom/language-javascript/pull/284
Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Added delete token #284

Merged
merged 1 commit into from
Dec 31, 2015
Merged

Added delete token #284

merged 1 commit into from
Dec 31, 2015

Conversation

Cxarli
Copy link
Contributor

@Cxarli Cxarli commented Dec 15, 2015

Added delete token as noted here
@50Wliu
Copy link
Contributor

50Wliu commented Dec 17, 2015

Are you sure this should be under meta.export.js?
@MaximSokolov
Copy link
Contributor

This rule is for var, let... in named exports:

export var x = 0;
export const CONSTANT = 0;
export let scopedVariable = 0;
export function func(p1, p2){}
export class Foo {}

btw, I moved these lines up in #276
@50Wliu
Copy link
Contributor

50Wliu commented Dec 31, 2015

Ok, thanks. I didn't notice that this rule as a whole was for exports.
50Wliu added a commit that referenced this pull request Dec 31, 2015
@50Wliu
Merge pull request #284 from C-Bouthoorn/patch-1
41aec15 
Added delete token
@50Wliu 50Wliu merged commit 41aec15 into atom:master Dec 31, 2015
@MaximSokolov
Copy link
Contributor

Sorry, I wasn't clear. export delete is not legit
@MaximSokolov MaximSokolov mentioned this pull request Dec 31, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants
@Cxarli @50Wliu @MaximSokolov @C-Bouthoorn