The Wayback Machine - https://web.archive.org/web/20221208022538/https://github.com/atom/language-javascript/pull/277
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenize let and var as storage.type.var.js #277

Merged
merged 1 commit into from Dec 3, 2015
Merged

Tokenize let and var as storage.type.var.js #277

merged 1 commit into from Dec 3, 2015

Conversation

50Wliu
Copy link
Member

@50Wliu 50Wliu commented Dec 3, 2015

#206 is back! 馃帀

Tested my changes locally and I think I can get everything working this time (it's hard to tell because I get ~50 spec failures on atom/atom). Will be pushing PRs to language-html and atom shortly.

/cc @atom/languages @slinto

Actually fixes #201

50Wliu added a commit to atom/language-html that referenced this pull request Dec 3, 2015
50Wliu added a commit that referenced this pull request Dec 3, 2015
Tokenize let and var as storage.type.var.js
@50Wliu 50Wliu merged commit 2771d82 into master Dec 3, 2015
@50Wliu 50Wliu deleted the wl-var-scope branch Dec 3, 2015
50Wliu added a commit to atom/atom that referenced this pull request Dec 3, 2015
@50Wliu
Copy link
Member Author

50Wliu commented Dec 3, 2015

Maybe not storage.type.var...does storage.type.constant sound better? /cc @MaximSokolov

@MaximSokolov
Copy link
Member

MaximSokolov commented Dec 4, 2015

storage.type.const or just storage.type as styles for constant can affect "constant" keyword
(see atom/language-go#63 (comment))

Related question: Is const in const int i; a "modifier" or it's storage.type as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants