The Wayback Machine - https://web.archive.org/web/20221207194803/https://github.com/atom/language-javascript/pull/272
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow $dollar$ signs in identifiers #272

Merged
merged 3 commits into from Nov 27, 2015
Merged

Allow $dollar$ signs in identifiers #272

merged 3 commits into from Nov 27, 2015

Conversation

MaximSokolov
Copy link
Member

@MaximSokolov MaximSokolov commented Nov 27, 2015 

0illegal()
$abc$()
$()
$obj$.$abc$()
$.$()
$.$
$.$prop$
$.CON$TANT
$.C$
class $
class $abc$ extends $
class extends $abc

Before:
before
After:
after

Fixes #270
Fixes #268
MaximSokolov
MaximSokolov reviewed Nov 27, 2015
View changes
grammars/javascript.cson
'beginCaptures':
'1':
'name': 'entity.name.function.js'
'name': 'invalid.illegal.js'
Copy link
Member Author

@MaximSokolov MaximSokolov Nov 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without invalid.illegal it would be ...(?:\\$+)?\\b[a-zA-Z_][\\w$]*)...
@Victorystick
Copy link
Member

Victorystick commented Nov 27, 2015

I'm loving this!
50Wliu added a commit that referenced this pull request Nov 27, 2015
@50Wliu
Merge pull request #272 from MaximSokolov/allow-dollar-signs-in-names
73040b7 
Allow $dollar$ signs in identifiers
@50Wliu 50Wliu merged commit 73040b7 into atom:master Nov 27, 2015
@MaximSokolov MaximSokolov deleted the allow-dollar-signs-in-names branch Nov 27, 2015
@50Wliu
Copy link
Member

50Wliu commented Nov 27, 2015

🍧

Wow. You're really on top of things @MaximSokolov.
@MaximSokolov MaximSokolov mentioned this pull request Dec 15, 2015
Closed
@50Wliu 50Wliu mentioned this pull request Jan 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under-review
3 participants
@MaximSokolov @Victorystick @50Wliu