The Wayback Machine - https://web.archive.org/web/20221208022540/https://github.com/atom/language-javascript/pull/260
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert argumetns matching #260

Merged
merged 1 commit into from Nov 19, 2015
Merged

Revert argumetns matching #260

merged 1 commit into from Nov 19, 2015

Conversation

MaximSokolov
Copy link
Member

@MaximSokolov MaximSokolov commented Nov 18, 2015

To properly tokenize arguments, functions' declarations (anything else?) should be tokenized first
Atom specs should be reverted as well...

Ref: #224 (Recognize function bodies)

To properly tokenize arguments, functions' declarations should be tokenized first
50Wliu added a commit that referenced this pull request Nov 19, 2015
@50Wliu 50Wliu merged commit 80c1c58 into atom:master Nov 19, 2015
@MaximSokolov MaximSokolov deleted the revert-arguments-matching branch Nov 19, 2015
@MaximSokolov
Copy link
Member Author

MaximSokolov commented Nov 19, 2015

I checked atom/atom#9655 It seems it shouldn't affect atom core specs, so new version can be released

@50Wliu
Copy link
Member

50Wliu commented Nov 19, 2015

I'll be publishing a new version once I get home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants