The Wayback Machine - https://web.archive.org/web/20220504211112/https://github.com/atom/language-html/pull/101
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favicon snippet #101

Merged
merged 2 commits into from Jan 11, 2016
Merged

Add favicon snippet #101

merged 2 commits into from Jan 11, 2016

Conversation

Hermanya
Copy link
Contributor

@Hermanya Hermanya commented Jan 10, 2016

No description provided.

50Wliu
50Wliu reviewed Jan 10, 2016
View changes
snippets/language-html.cson
@@ -110,6 +110,9 @@
'prefix': 'embed'
'body': '<embed type="${1:video/quicktime}" src="${2:#}" width="${3:300}" height="${4:300}">$0'
# F
'Favicon':
'prefix': 'favicon'
'body': '<link rel="shortcut icon" href="$1.ico" />$0'
Copy link
Member

@50Wliu 50Wliu Jan 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other self-closing tags in this file seem to use just > instead of />. To fit in more I would suggest <link rel="shortcut icon" href="$1.ico">$0.
@Hermanya
Copy link
Author

@Hermanya Hermanya commented Jan 11, 2016

I removed the slash
50Wliu added a commit that referenced this issue Jan 11, 2016
@50Wliu
Merge pull request #101 from Hermanya/patch-1
43a17c9 
Add favicon snippet
@50Wliu 50Wliu merged commit 43a17c9 into atom:master Jan 11, 2016
1 check failed
@50Wliu
Copy link

@50Wliu 50Wliu commented Jan 11, 2016

Thanks!
@Hermanya Hermanya deleted the patch-1 branch Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Hermanya @50Wliu