This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Prevent 'getSelectedBufferRanges' uncaught exception #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to create a spec for this? |
ProblemFind and replace crash when you try to toogle options such as regex in a non-text tab (i.e img,etc. Cf repro in #619) CorrectionIf the tab isn't a text tab, the editor object will be none I just had to handle it in anyMarkersAreSelected. Futhermore, there is no markers available, so, handle this in selectFirstMarker* Sorry for my bad english |
|
What I meant was, can you write some automated tests to ensure that we don't accidentally break this fix in the future? |
lee-dohm
changed the title
|
Done |
lee-dohm
added a commit
that referenced
this pull request
Feb 1, 2016
Prevent 'getSelectedBufferRanges' uncaught exception
|
Thanks for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just fixes #619