The Wayback Machine - https://web.archive.org/web/20221207052655/https://github.com/atom/find-and-replace/pull/613
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show search wrap icon when scroll position changed #613

Merged
merged 1 commit into from Dec 11, 2015

Conversation

maxbrunsfeld
Copy link
Contributor

@maxbrunsfeld maxbrunsfeld commented Dec 7, 2015

I think @nathansobo, @kevinsawicki and I have all found it annoying that the icon shows up even if the editor does not scroll.

@nathansobo
Copy link
Contributor

nathansobo commented Dec 7, 2015

Awesome. Thanks for jumping on this!

@maxbrunsfeld maxbrunsfeld force-pushed the mb-only-show-wraparound-when-scrolling branch from b32ad6b to 94f9418 Compare Dec 7, 2015
@maxbrunsfeld
Copy link
Contributor Author

maxbrunsfeld commented Dec 7, 2015

The build is failing due to a bug in v1.2.3 that is fixed on beta. I think I'll just wait to ship this until we roll the railcars on Wednesday.

maxbrunsfeld pushed a commit that referenced this pull request Dec 11, 2015
Only show search wrap icon when scroll position changed
@maxbrunsfeld maxbrunsfeld merged commit bab2e42 into master Dec 11, 2015
@maxbrunsfeld maxbrunsfeld deleted the mb-only-show-wraparound-when-scrolling branch Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants