This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Catch scanInBufferRange errors #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/buffer-search.coffee
|
I believe this is ready for review now - /cc @atom/feedback. |
| describe "when the search string is too large", -> | ||
| beforeEach -> | ||
| largeText = "abcdefghijklmnopqrstuvwxyz" | ||
| largeText += "abcdefghijklmnopqrstuvwxyz" for num in [0...2000] |
There was a problem hiding this comment.
Is there a better way to populate the find box with an absolutely massive search string? I believe when I first investigated this through trial and error the max regex length was 32768 (this method gives around 50000 characters just to be safe).
There was a problem hiding this comment.
In the past, we've created a spec/fixtures folder and stored files there for large quantities of text. This way you can create a test file and just read from it without having to do stuff like this in the test.
There was a problem hiding this comment.
I think if the goal is just to create a long string, you should just do "x".repeat(50000).
This was accidentally added back in during the merge conflict I think...it was removed in #583
|
Dope. Thanks @50Wliu! |
50Wliu
added a commit
that referenced
this pull request
Feb 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will catch
RegExp too bigerrors and properly display them in the find box instead of a) displaying a uncaught exception, b) breaking tab switching, and c) (sometimes) preventing the find box from being usable.TODO:
RegExp too bigshould suffice) - changed to "Search string is too large"Fixes #510
Fixes #532