Make updating matches faster for multi-cursor editing #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, avoid updating the bracket matcher when the cursor moves because of a text change. That scenario is already handled by the `onDidChangeText` event.
|
Awesome! |
as-cii
added a commit
that referenced
this pull request
Feb 19, 2016
Make updating matches faster for multi-cursor editing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With this PR we make use of the new
TextBuffer.prototype.onDidChangeTextAPI and we also avoid to update bracket matches when the cursor moves because of a text change, because that scenario is already handled by theonDidChangeTextevent.Before
(Total:
~ 240ms, benchmark performed by editing 500 lines, inserting 5 characters)After
(Total:
~ 4ms, 60x faster)/cc: @nathansobo @maxbrunsfeld