The Wayback Machine - https://web.archive.org/web/20221207052804/https://github.com/atom/autocomplete-plus/pull/681
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximum call stack size exceeded error #681

Merged
merged 1 commit into from Mar 1, 2016

Conversation

as-cii
Copy link
Contributor

@as-cii as-cii commented Feb 29, 2016

Closes #679. I believe that was caused by the stack growing because of Array.prototype.splice that requires the ... operator, hence making the parameter list humongous.

/cc: @benogle

@benogle
Copy link
Contributor

benogle commented Feb 29, 2016

👍

as-cii added a commit that referenced this pull request Mar 1, 2016
Fix maximum call stack size exceeded error
@as-cii as-cii merged commit ab6a36c into master Mar 1, 2016
@as-cii as-cii deleted the as-fix-exceeded-call-stack-size branch Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants