Stop flickering when adjusting margins #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon further inspection, it seems like the replaced code was introduced to batch writes for a performance concern; removing it, though, doesn't seem to affect performance in a significant/noticeable way. @benogle: what's the likelihood of layout thrashing here? Is there any particular scenario I am not thinking of? |
Definitely. I may have been a little too eager with the optimization. This seems fine, especially if you arent seeing any perf regression. |
|
|
as-cii
added a commit
that referenced
this pull request
Jan 28, 2016
Stop flickering when adjusting margins
|
Thanks @benogle for the heads-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
See atom/atom#8295 (comment) for more information about why this happens.
With this PR we prevent margins to be adjusted across two different animation frames, which causes the autocompletion box to flicker.
/cc: @benogle for馃憖