Don't overwrite non-word characters that match replacement suffixes #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good solution |
|
LGTM! |
|
Ok, both the appveyor failures were an off-by-one pixel position error. I don't think they're related to this PR, so I'm going to |
maxbrunsfeld
pushed a commit
that referenced
this pull request
Dec 3, 2015
Don't overwrite non-word characters that match replacement suffixes
|
@nmote This will be in Atom v1.4.0 (and v1.4.0-beta0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This avoids overwriting characters in
editor.nonWordCharacterswhen they follow the cursor and match a suffix of the autocomplete text.This mainly comes up when the replacement text is a function call ending with
). Currently, when a)already follows the cursor, it gets overwritten by the autocomplete text, which is usually not what the user wants.Refs #628
/cc @benogle @nmote