The Wayback Machine - https://web.archive.org/web/20221208022627/https://github.com/atom/autocomplete-plus/pull/622
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use atom.workspace.isTextEditor when available #622

Merged
merged 2 commits into from Nov 23, 2015
Merged

Use atom.workspace.isTextEditor when available #622

merged 2 commits into from Nov 23, 2015

Conversation

as-cii
Copy link
Contributor

@as-cii as-cii commented Nov 20, 2015

We've introduced a new function to understand whether an object is a TextEditor or not in atom/atom#9711.

This PR makes use of it to fix #614.

/cc: @benogle @atom/feedback
@as-cii
Copy link
Contributor Author

as-cii commented Nov 20, 2015

I think AppVeyor's result is a false negative 😞 but I think this is good to go! 👍
@benogle
Copy link
Contributor

benogle commented Nov 20, 2015

Cool 👍
as-cii added a commit that referenced this pull request Nov 23, 2015
@as-cii
Merge pull request #622 from atom/as-use-is-text-editor
db35d7a 
Use atom.workspace.isTextEditor when available
@as-cii as-cii merged commit db35d7a into master Nov 23, 2015
@as-cii as-cii deleted the as-use-is-text-editor branch Nov 23, 2015
@Arcanemagus Arcanemagus mentioned this pull request Dec 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@as-cii @benogle