The Wayback Machine - https://web.archive.org/web/20221207052714/https://github.com/atom/atom/pull/10377
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release-notes #10377

Merged
merged 4 commits into from Jan 13, 2016
Merged

Remove release-notes #10377

merged 4 commits into from Jan 13, 2016

Conversation

joshaber
Copy link
Contributor

@joshaber joshaber commented Jan 11, 2016

Since it’s been reporting the wrong release notes, it’s doing more harm than good 😞

We’ll link to the release notes from About now.

/cc @atom/feedback

@joshaber
Copy link
Contributor Author

joshaber commented Jan 11, 2016

I'll back port this onto stable once it's merged.

@@ -102,7 +102,6 @@
"notifications": "0.62.1",
"open-on-github": "0.40.0",
"package-generator": "0.41.0",
"release-notes": "0.53.0",
Copy link
Member

@kevinsawicki kevinsawicki Jan 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 💚

@50Wliu
Copy link
Member

50Wliu commented Jan 11, 2016

Refs (and should close) #10055.

@mnquintana
Copy link
Member

mnquintana commented Jan 11, 2016

Is this going to change the update flow at all? (Like, will there now be no status bar squirrel indicating a new version's available / been installed, for instance?)

@benogle
Copy link
Contributor

benogle commented Jan 11, 2016

Is this going to change the update flow at all? (Like, will there now be no status bar squirrel indicating a new version's available / been installed, for instance?)

This. I think the status bar squirrel is done in the release notes package, but that logic could move to the about package.

@lee-dohm
Copy link
Contributor

lee-dohm commented Jan 12, 2016

Also should close #5692

@joshaber
Copy link
Contributor Author

joshaber commented Jan 12, 2016

I think the status bar squirrel is done in the release notes package, but that logic could move to the about package.

Or perhaps the status-bar package itself?

@joshaber joshaber changed the title Remove release-notes [WIP] Remove release-notes Jan 12, 2016
@lee-dohm
Copy link
Contributor

lee-dohm commented Jan 12, 2016

Or perhaps the status-bar package itself?

👍 I like this idea.

@simurai
Copy link
Member

simurai commented Jan 12, 2016

There is also atom/about#5, so the about package would fit too in case that direction will move forward.

@joshaber
Copy link
Contributor Author

joshaber commented Jan 12, 2016

Ah, good point @simurai. I'll go with about then 👍

@joshaber
Copy link
Contributor Author

joshaber commented Jan 13, 2016

Once this goes green I'll merge and cherry-pick it into stable so it can go out in 1.4.0.

@joshaber joshaber changed the title [WIP] Remove release-notes Remove release-notes Jan 13, 2016
@benogle
Copy link
Contributor

benogle commented Jan 13, 2016

Cool 👍

cherry-pick it into stable

beta?

@joshaber
Copy link
Contributor Author

joshaber commented Jan 13, 2016

cherry-pick it into stable

beta?

Yeah or that. Basically the same AFAICT since they'll both be rolled into 1.4.0.

@joshaber
Copy link
Contributor Author

joshaber commented Jan 13, 2016

Looks like the about specs are hanging on janky for some reason.

@joshaber
Copy link
Contributor Author

joshaber commented Jan 13, 2016

Well, it passed on janky-osx4 and Travis so it seems to be a problem specific to janky-osx2.

joshaber added a commit that referenced this pull request Jan 13, 2016
@joshaber joshaber merged commit 3ed8f01 into master Jan 13, 2016
@joshaber joshaber deleted the remove-release-notes branch Jan 13, 2016
joshaber added a commit that referenced this pull request Jan 13, 2016
@joshaber
Copy link
Contributor Author

joshaber commented Jan 13, 2016

Cherry picked into beta: d229fed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants