New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove release-notes #10377
Remove release-notes #10377
Conversation
|
I'll back port this onto |
| @@ -102,7 +102,6 @@ | |||
| "notifications": "0.62.1", | |||
| "open-on-github": "0.40.0", | |||
| "package-generator": "0.41.0", | |||
| "release-notes": "0.53.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Refs (and should close) #10055. |
|
Is this going to change the update flow at all? (Like, will there now be no status bar squirrel indicating a new version's available / been installed, for instance?) |
This. I think the status bar squirrel is done in the release notes package, but that logic could move to the about package. |
|
Also should close #5692 |
Or perhaps the |
|
|
There is also atom/about#5, so the about package would fit too in case that direction will move forward. |
|
Ah, good point @simurai. I'll go with |
|
Once this goes green I'll merge and cherry-pick it into stable so it can go out in 1.4.0. |
|
Cool
beta? |
Yeah or that. Basically the same AFAICT since they'll both be rolled into 1.4.0. |
|
Looks like the about specs are hanging on janky for some reason. |
|
Well, it passed on janky-osx4 and Travis so it seems to be a problem specific to janky-osx2. |
|
Cherry picked into |


Since it’s been reporting the wrong release notes, it’s doing more harm than good😞
We’ll link to the release notes from About now.
/cc @atom/feedback